[PATCH] D50241: Fix tests for changed opt remarks format

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 5 07:54:05 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rC338971: Fix tests for changed opt remarks format (authored by xbolva00, committed by ).
Herald added a subscriber: cfe-commits.

Repository:
  rC Clang

https://reviews.llvm.org/D50241

Files:
  test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
  test/Frontend/optimization-remark-with-hotness.c


Index: test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
===================================================================
--- test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
+++ test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
@@ -19,17 +19,18 @@
 ; YAML-NEXT:   - Callee:          tinkywinky
 ; YAML-NEXT:   - String:          ' inlined into '
 ; YAML-NEXT:   - Caller:          main
-; YAML-NEXT:   - String:          ' with cost='
+; YAML-NEXT:   - String:          ' with '
+; YAML-NEXT:   - String:          '(cost='
 ; YAML-NEXT:   - Cost:            '0'
-; YAML-NEXT:   - String:          ' (threshold='
+; YAML-NEXT:   - String:          ', threshold='
 ; YAML-NEXT:   - Threshold:       '337'
 ; YAML-NEXT:   - String:          ')'
 ; YAML-NEXT: ...
 
 ; Next try with pass remarks to stderr
 ; RUN: %clang -target x86_64-scei-ps4 -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -mllvm -pass-remarks=inline -fdiagnostics-show-hotness -o %t2.o -c 2>&1 | FileCheck %s
 
-; CHECK: tinkywinky inlined into main with cost=0 (threshold=337) (hotness: 300)
+; CHECK: tinkywinky inlined into main with (cost=0, threshold=337) (hotness: 300)
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-scei-ps4"
Index: test/Frontend/optimization-remark-with-hotness.c
===================================================================
--- test/Frontend/optimization-remark-with-hotness.c
+++ test/Frontend/optimization-remark-with-hotness.c
@@ -60,13 +60,13 @@
   // THRESHOLD-NOT: hotness
   // NO_PGO: '-fdiagnostics-show-hotness' requires profile-guided optimization information
   // NO_PGO: '-fdiagnostics-hotness-threshold=' requires profile-guided optimization information
-  // expected-remark at +1 {{foo inlined into bar with cost=always (hotness:}}
+  // expected-remark at +1 {{foo inlined into bar with (cost=always): always inliner (hotness:}}
   sum += foo(x, x - 2);
 }
 
 int main(int argc, const char *argv[]) {
   for (int i = 0; i < 30; i++)
-    // expected-remark at +1 {{bar not inlined into main because it should never be inlined (cost=never) (hotness:}}
+    // expected-remark at +1 {{bar not inlined into main because it should never be inlined (cost=never): always inliner (hotness:}}
     bar(argc);
   return sum;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50241.159215.patch
Type: text/x-patch
Size: 2310 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180805/1b2689e0/attachment.bin>


More information about the cfe-commits mailing list