[PATCH] D50099: [DebugInfo][OpenCL] Address post-commit review of D49930

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 5 07:44:53 PDT 2018

echristo added a comment.

Looks pretty good. Could you pass CGM in and just make the functions static I couldn't see any other class variables, but might have missed something. One inline comment as well.


Comment at: lib/CodeGen/CGDebugInfo.cpp:997
   llvm::DINode::DIFlags Flags = llvm::DINode::FlagAppleBlock;
   unsigned LineNo = 0;
Just noticed that LineNo is 0... for the entire function.


More information about the cfe-commits mailing list