[PATCH] D50055: Update the coding standard about NFC changes and whitespace

Chandler Carruth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 4 20:34:48 PDT 2018

chandlerc added inline comments.

Comment at: docs/CodingStandards.rst:514-516
+line of code. Some common editors will automatically remove trailing whitespace
+when saving a file which causes unrelated changes to appear in diffs and
Meinersbur wrote:
> Just to note that this policy will prohibit the use of remove trailing-whitespace feature in editors since it makes it impossible to edit the file without also 'editing' any unrelated whitespace. At the same time, since not being able to use the feature, I risk committing trailing whitespace myself (that is, some additional steps are necessary: I use 'git clang-format' which should remove traling whitespace only on edited lines and 'git diff' shows trailing whitespace in red; these are still additional steps that are easy to miss)
I also have editor settings that risk violating this, but I just reduce my patdh before submitting. This is a touch annoying with svn, but with got it is pretty simple to use `git add -p` and ignore the unnecessary removals if trailing whitespace 


More information about the cfe-commits mailing list