[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 18:11:01 PDT 2018

rjmccall added inline comments.

Comment at: lib/CodeGen/CGExpr.cpp:521
+          CGM.getCodeGenOpts().OptimizationLevel > 0 &&
+          !CGM.getCodeGenOpts().SanitizeAddressUseAfterScope) {
+        OldConditional = OutermostConditional;
Why only when optimization is enabled?  This seems like a nice improvement regardless.

Also, please mention why this is disabled for destructed types in the comment, not just the commit message.


More information about the cfe-commits mailing list