[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

Matt Morehouse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 14:44:23 PDT 2018

morehouse added a comment.

In https://reviews.llvm.org/D50194#1187756, @emmettneyman wrote:

> An unrelated question:
>  Right now I have a mix of `static` and non-`static` functions in `handle_llvm.cpp`. Should they all be `static`?

Any functions that are only used in the same file can and should be `static` or in an unnamed namespace.  Functions that implement something from a header file must not be `static`.

  rC Clang


More information about the cfe-commits mailing list