r338884 - [NFC] Silence unused variable warning in Attr.td/AttrParsedAttrImpl.inc

Keane, Erich via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 06:23:56 PDT 2018

Thanks for the heads up!  I repro’ed both in Godbolt, and saw that clang suggests wrapping in a void-cast, so I’ve done  that.

From: Nico Weber [mailto:thakis at chromium.org]
Sent: Friday, August 3, 2018 6:16 AM
To: Keane, Erich <erich.keane at intel.com>
Cc: cfe-commits <cfe-commits at lists.llvm.org>
Subject: Re: r338884 - [NFC] Silence unused variable warning in Attr.td/AttrParsedAttrImpl.inc

This causes a warning:

gen/clang/include/clang/Sema/AttrParsedAttrImpl.inc:1050:12: warning: expression result unused [-Wunused-value]
    return S, false;

On Fri, Aug 3, 2018 at 9:01 AM Erich Keane via cfe-commits <cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>> wrote:
Author: erichkeane
Date: Fri Aug  3 06:01:32 2018
New Revision: 338884

URL: http://llvm.org/viewvc/llvm-project?rev=338884&view=rev
[NFC] Silence unused variable warning in Attr.td/AttrParsedAttrImpl.inc


Modified: cfe/trunk/include/clang/Basic/Attr.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Attr.td?rev=338884&r1=338883&r2=338884&view=diff
--- cfe/trunk/include/clang/Basic/Attr.td (original)
+++ cfe/trunk/include/clang/Basic/Attr.td Fri Aug  3 06:01:32 2018
@@ -145,7 +145,7 @@ def HasFunctionProto : SubsetSubject<Dec
 // function. Accepted as a function type attribute on the type of such a
 // member function.
 // FIXME: This does not actually ever match currently.
-def ImplicitObjectParameter : SubsetSubject<Function, [{false}],
+def ImplicitObjectParameter : SubsetSubject<Function, [{S, false}],
                                             "implicit object parameters">;

 // A single argument to an attribute

cfe-commits mailing list
cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180803/f9d033df/attachment.html>

More information about the cfe-commits mailing list