[PATCH] D50214: Add inherited attributes before parsed attributes.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 05:57:22 PDT 2018

erichkeane added a comment.

IMO, I think this (and the next 2 numerically), show to me that we have too much dependence on the order of attributes, which all of these show is not a reliable thing to count on.  I quite dislike this as well, and think this is going to lead us to chasing these same issues forever.

I wonder if the solution here is to just sort the attributes by source location?  This would create that guarantee, which previously didn't exist.

  rC Clang


More information about the cfe-commits mailing list