[PATCH] D48100: Append new attributes to the end of an AttributeList.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 05:53:36 PDT 2018

erichkeane added a comment.

In https://reviews.llvm.org/D48100#1186654, @Meinersbur wrote:

> I have two approaches to tackle the wrong marker order: https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216. IMHO both are too invasive to be justified for the small issue.

I think you're right here.  I despise https://reviews.llvm.org/D50215, and only mostly hate https://reviews.llvm.org/D50216.  I think I'd prefer leaving this as a "FIXME" somewhere.



More information about the cfe-commits mailing list