[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 02:07:32 PDT 2018

Szelethus marked 2 inline comments as done.
Szelethus added a comment.

It looks like I won't be back in office until Monday, so I can't finish this one until then :(

>> but I haven't seen the current version of the checker crash due to pointer chasing.
> @NoQ saw quite a few crashes during evaluation, right?

That doesn't sound any good. I'd be very interested in fixing those. Any plans to make some bugreports on bugzilla?

>> This might be a little nit-picking, but I don't think the finds are false positive
> Well, yeah, it depends on how do you define things. If we define reports as "bugs", then I guess this checker already does not find bugs, but best-practices violations.
>  Then it can be argued whether "best practice" should be extended to include all the memory reachable through pointers.

Fair point. I still am very confident that pointer chasing should be a thing, but I strongly agree that it lacks good heuristics to make the reports more meaningful.


More information about the cfe-commits mailing list