[PATCH] D50189: Fully qualify the renamed symbol if the shortened name is ambiguous.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 01:19:14 PDT 2018

ioeric added inline comments.

Comment at: lib/Tooling/Core/Lookup.cpp:139
+    const NamespaceDecl *NS = *I;
+    auto LookupRes = NS->lookup(DeclarationName(&AST.Idents.get(Head)));
+    if (!LookupRes.empty()) {
ilya-biryukov wrote:
> This will not take using namespaces into account, right? Do we care about those or is this a known limitation of the tools?
Right, I think we don't handle using namespaces in this library due to limitation/importance etc. Added a FIXME.

  rC Clang


More information about the cfe-commits mailing list