[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

Dustin L. Howett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 2 21:51:21 PDT 2018


DHowett-MSFT added a subscriber: smeenai.
DHowett-MSFT added inline comments.


================
Comment at: include/clang/Driver/Options.td:1491
 // Objective-C ABI options.
-def fobjc_runtime_EQ : Joined<["-"], "fobjc-runtime=">, Group<f_Group>, Flags<[CC1Option]>,
+def fobjc_runtime_EQ : Joined<["-"], "fobjc-runtime=">, Group<f_Group>, Flags<[CC1Option, CoreOption]>,
   HelpText<"Specify the target Objective-C runtime kind and version">;
----------------
Is this so it's exposed to clang-cl?


================
Comment at: lib/AST/MicrosoftMangle.cpp:1886
   case BuiltinType::ObjCId:
-    mangleArtificalTagType(TTK_Struct, "objc_object");
+    mangleArtificalTagType(TTK_Struct, ".objc_object");
     break;
----------------
I'm interested in @smeenai's take on this, as well.


Repository:
  rC Clang

https://reviews.llvm.org/D50144





More information about the cfe-commits mailing list