[PATCH] D50216: Pass IsInherited when merging attribute lists [RFC]

[Michael Kruse via Phabricator via cfe-commits]

Meinersbur created this revision.
Herald added subscribers: cfe-commits, eraman.

Attempt to solve the the diagnostic marker order ('note: previous declaration here' pointing to a source location before the main error marker) from https://reviews.llvm.org/D48100.

The approach is to pass a `IsInherited` parameters. If false, the order if the diagnostic marker is reversed.

The actual reversal is only implemented for two diagnoses: `diag::err_mismatched_visibility` and `diag::err_ownership_returns_index_mismatch`. Test cases not adapted.


Repository:
  rC Clang

https://reviews.llvm.org/D50216

Files:
  include/clang/Sema/Sema.h
  lib/Parse/ParseCXXInlineMethods.cpp
  lib/Parse/ParseDeclCXX.cpp
  lib/Parse/ParseStmt.cpp
  lib/Sema/SemaAttr.cpp
  lib/Sema/SemaDecl.cpp
  lib/Sema/SemaDeclAttr.cpp
  lib/Sema/SemaDeclCXX.cpp
  lib/Sema/SemaDeclObjC.cpp
  lib/Sema/SemaExpr.cpp
  lib/Sema/SemaLambda.cpp
  lib/Sema/SemaObjCProperty.cpp
  lib/Sema/SemaTemplate.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50216.158895.patch
Type: text/x-patch
Size: 27125 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180803/04111921/attachment-0001.bin>