[PATCH] D50199: [MinGW] Predefine UNICODE if -municode is specified during compilation
Pirama Arumuga Nainar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 2 13:58:41 PDT 2018
pirama added a comment.
In https://reviews.llvm.org/D50199#1186164, @rnk wrote:
> Does this do anything other than -DUNICODE? Maybe just translate it at the driver level and skip the -cc1 flag?
It seems odd to include predefined macros at the driver, which AFAIK is just a bridge to the frontend's command-line interface. OTOH, there is other precedence for doing this - during clang-cl's argument processing. So I don't have a strong opinion here.
https://reviews.llvm.org/D50199
More information about the cfe-commits
mailing list