[PATCH] D50199: [MinGW] Predefine UNICODE if -municode is specified during compilation

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 2 13:11:06 PDT 2018

mstorsjo added a comment.

In https://reviews.llvm.org/D50199#1186164, @rnk wrote:

> Does this do anything other than -DUNICODE? Maybe just translate it at the driver level and skip the -cc1 flag?

Yes, that also works. Initially I looked at where to place that in lib/Driver/ToolChains/MinGW.cpp, but I see that it should be in lib/Driver/ToolChains/Clang.cpp (I presume?).

  rC Clang


More information about the cfe-commits mailing list