[PATCH] D50189: Fully qualify the renamed symbol if the shortened name is ambiguous.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 2 08:06:39 PDT 2018


ioeric created this revision.
ioeric added reviewers: ilya-biryukov, hokein.
Herald added a subscriber: cfe-commits.

For example, when renaming `a::b::x::foo` to `y::foo` below, replacing
`x::foo()` with `y::foo()` can cause ambiguity. In such cases, we simply fully
qualify the name with leading `::`.
namespace a {
namespace b {
namespace x { void foo() {} }
namespace y { void foo() {} }
}
}

namespace a {
namespace b {
void f() { x::foo(); }
}
})");


Repository:
  rC Clang

https://reviews.llvm.org/D50189

Files:
  lib/Tooling/Core/Lookup.cpp
  unittests/Tooling/LookupTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50189.158759.patch
Type: text/x-patch
Size: 4431 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180802/33c73820/attachment.bin>


More information about the cfe-commits mailing list