[PATCH] D48100: Append new attributes to the end of an AttributeList.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 2 06:19:26 PDT 2018

erichkeane added a comment.

In https://reviews.llvm.org/D48100#1185189, @hfinkel wrote:

> Assuming that @aaron.ballman is still okay with this, I think that we should move forward. @erichkeane, I suspect that fixing the ordering problems, which were often arbitrary before and are still so, is a larger change that we'd want to split out regardless (not to mention the fact that we'd need to decide how to fix them). Erich, is that alright with you?

That works fine with me.  I'm still concerned about the ordering issues, since I think the error-on-the-second made more sense in the past, but after digging in for a bit, I think it is perhaps not worth the effort.  I'm OK if @aaron.ballman is.

  rC Clang


More information about the cfe-commits mailing list