[PATCH] D50154: [clangd] capitalize diagnostic messages if '-capitialize-diagnostic-text' is provided

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 2 04:52:17 PDT 2018

ioeric added a comment.

In https://reviews.llvm.org/D50154#1185545, @ilya-biryukov wrote:

> Maybe we could simply always capitalize the messages? Any cons to capitalizing error messages?
>  @simark, @malaperle, @ioeric, @hokein, WDYT?

Oh sorry, I thought `-capitialize-diagnostic-text` was an existing clang flag, in which case we should respect it. I don't think there is any con that I could think of, as long as it looks nice in clients :)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list