[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 1 12:19:14 PDT 2018


mgrang added inline comments.


================
Comment at: lib/CodeGen/CGBlocks.cpp:1593
+  // Sort the captures by offset.
+  std::sort(ManagedCaptures.begin(), ManagedCaptures.end());
 }
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements


Repository:
  rC Clang

https://reviews.llvm.org/D50152





More information about the cfe-commits mailing list