[PATCH] D49922: [P0936R0] add [[clang::lifetimebound]] attribute

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith marked 3 inline comments as done.
rsmith added inline comments.


================
Comment at: lib/Sema/SemaInit.cpp:6959
+      case IndirectLocalPathEntry::LifetimeBoundCall:
+        // FIXME: Consider adding a note for this.
+        break;
----------------
aaron.ballman wrote:
> Is this something you intended to handle in this patch and forgot, or are you saving this for a future patch?
It's something I'm going to experiment with and see if it improves the diagnostic quality, but not for this patch.


================
Comment at: test/SemaCXX/attr-lifetimebound.cpp:4
+namespace usage_invalid {
+  // FIXME: Diagnose void return type?
+  void voidreturn(int &param [[clang::lifetimebound]]);
----------------
aaron.ballman wrote:
> Something you intended to support in this patch?
More like an open question for the standards proposal. I've slightly reworded the FIXME to indicate that this is an open question.


https://reviews.llvm.org/D49922