[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 15:02:26 PDT 2018

erik.pilkington added a comment.

In https://reviews.llvm.org/D46845#1183435, @mclow.lists wrote:

> One more thing - 
>  When you add a new header file, you need to update `include/module.modulemap`, `test/libcxx/double_include.sh.cpp`, and `include/CMakeLists.txt`.
>  Take a look at https://reviews.llvm.org/D49338 for an example.

Are you sure we have to update test/libcxx/double_include.sh.cpp? Looks like that file only has public headers, but this patch only adds `__node_handle`, which is internal. The new patch adds this header to include/CMakeLists.txt though (`__node_handle` already appeared in module.modulemap)


More information about the cfe-commits mailing list