[PATCH] D50055: Update the coding standard about NFC changes and whitespace

[Chandler Carruth via Phabricator via cfe-commits]

chandlerc added inline comments.


================
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+---------------------------------
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code if the changes being made are obvious and
+not invasive. For instance, removing trailing whitespace from a line, fixing a
+line ending to be consistent with the rest of the file, fixing a typo, code
----------------
I think this is a much broader statement than is warranted to address the specific problem. And I'm not completely comfortable with it.

I don't think guidance around "no functional change" is the right way to give guidance about what is or isn't "obvious" and fine to commit with post-commit review personally.

I'd really suggest just being direct about *formatting* and whitespace changes, and specifically suggest that they not be made unless the file or code region in question is an area that the author is planning subsequent changes to.


https://reviews.llvm.org/D50055