[PATCH] D49953: [compiler-rt] Add a routine to specify the mode used when creating profile dirs.

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 13:54:12 PDT 2018

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

Using `%t` with suffixes instead of `%T` is the preferred idiom, glad you worked that out.
The more elaborate test depends on a set of Posix-y calls, but that's fine.  If there are more environments that can't handle it, the bots will find them for you. :-)
LGTM with the fancier test, once you fix the missing RUN.  (The RUN prefixes are how lit decides which lines are the test script.)

Comment at: test/profile/instrprof-set-dir-mode2.c:3
+// RUN: %clang_pgogen -o %t.bin %s -DTESTPATH=\"%t.dir\"
+// rm -rf %t.dir
+// RUN: %run %t.bin
This needs a RUN: in front of it, I think.


More information about the cfe-commits mailing list