[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 12:02:29 PDT 2018

rnk added subscribers: hans, thakis, samsonov, rnk.
rnk added a comment.

+ at thakis @hans

I think this broke Chromium's distributed Mac ASan build.

I personally found the error message confusing for the reasons that @samsonov mentioned back in 2015. It's not that ASan wasn't supported on the platform, it's just that the runtime library didn't happen to exist on the system performing compilation. If this is going to be based on a filesystem test, the diagnostic should be more mechanical in nature, i.e. actually tell the user that some required file doesn't exist.

In the meantime, I would like to revert this. I don't think our distributed build use case is that exotic, and I expect other users of distcc and icecreamcc will have similar issues with this change.



More information about the cfe-commits mailing list