[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:1
+// RUN: %clang_cc1 %s -emit-llvm -o -
+
----------------
erichkeane wrote:
> First, most of this test can be further simplified.  Second, I'd like to see a test that actually tests the limit without hitting the recursive template limit.
> First, most of this test can be further simplified.
OK? This is what creduce gave me. But yes, i know it has some issues with templates.

> Second, I'd like to see a test that actually tests the limit without hitting the recursive template limit.
But that is true already. *this* test does not hit the recursive template limit.


================
Comment at: test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:20
+  // not fit it, so we are testing that we do fit it.
+  // If -ftemplate-depth= is provided, larger values (4096 and up) cause crashes
+  // elsewhere.
----------------
erichkeane wrote:
> Shouldn't we cover 16k?  
No, for me `4096` already crashes elsewhere.


Repository:
  rC Clang

https://reviews.llvm.org/D50050