[PATCH] D49794: [libclang] Allow skipping warnings from all included files

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 07:41:16 PDT 2018

ilya-biryukov added a comment.

In https://reviews.llvm.org/D49794#1182296, @yvvan wrote:

> Clang tidy is not only a standalone tool but also a plugin. It's almost never used this way (but we do that in Qt Creator to combine it with Clazy) and it also seems that some of the recent checks are added only to standalone tool (which is easy to fix).
>  Being loaded into clang as plugin it does not support most of clang-tidy command line options and is not able to filter system includes. I'm not sure it's possible to fix both of these issues (and probably some other).

Oh, I see, thanks for the pointers. Not related to this discussion, it seems reasonable to allow all the same options to be passed into clang-tidy plugin, not sure if that's easy or hard in principle to fix it.

The added option seems like a workaround for a bug in clang-tidy and a windows locking bug (which is blocker for tools like clangd and libclang-based integrations, IMO). I would still vouch for fixing the bugs than adding flags that try to workaround those bugs.


More information about the cfe-commits mailing list