[PATCH] D49794: [libclang] Allow skipping warnings from all included files

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

In https://reviews.llvm.org/D49794#1182220, @yvvan wrote:

> And we already saw, that -isystem is not the best choice for that.


Are you referring to the file-locking on Windows? 
Any other reasons why the -isystem trick might be non-ideal?

> And by the way - clang-tidy has this filtering in consumer which does not exist in it's plugin-mode so it spits all system diagnostics all the time...

I would still argue against adding this option in the current form to the compiler. I don't see how that might be useful to non-clang-tidy, non-editor-integration users.

What's the 'plugin mode' of clang-tidy? I don't seem to able to Google it :-)


https://reviews.llvm.org/D49794