[PATCH] D49794: [libclang] Allow skipping warnings from all included files

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 06:06:01 PDT 2018

ilya-biryukov added a comment.

In https://reviews.llvm.org/D49794#1182078, @yvvan wrote:

> I already mentioned in the review inherited by this one that this way covers also loaded plugins with different consumers. So let's assume that driver loads clang-tidy and some other plugins and runs over each file in the project.
>  It makes sense not to include clang-tidy diagnostics coming from headers, at least for third-party headers (you can still run clang over specific headers themselves to get diagnostics for them).

For third-party headers, sure (as I mentioned before, we already use -isystem include directive for third party libs to achieve the same thing). But ignoring diagnostics from **all** the headers does not seem particularly useful.


More information about the cfe-commits mailing list