[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 17:16:06 PDT 2018

rnk added inline comments.

Comment at: test/CodeGen/exceptions-seh.c:10
+// RUN: %clang_cc1 %s -triple aarch64-windows -fms-extensions -emit-llvm -o - \
+// RUN:         | FileCheck %s --check-prefix=X64-GNU
mgrang wrote:
> Is it OK to re-use the X64-GNU check prefix here or should I create one called X64-MS?
I'd put this before the GNU tests after the MS tests, since that's what it's targeting. You can include the CHECK lines with `--check-prefixes=CHECK,ARM64`.

Comment at: test/CodeGen/exceptions-seh.c:33
 // CHECK-LABEL: define dso_local i32 @safe_div(i32 %numerator, i32 %denominator, i32* %res)
 // X64-SAME:      personality i8* bitcast (i32 (...)* @__C_specific_handler to i8*)
 // X86-SAME:      personality i8* bitcast (i32 (...)* @_except_handler3 to i8*)
Looks like ARM64 wants __C_specific_handler as well.

  rC Clang


More information about the cfe-commits mailing list