[PATCH] D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 13:58:42 PDT 2018

echristo added a comment.

In https://reviews.llvm.org/D49930#1181000, @scott.linder wrote:

> Sorry, I didn't see the additional comments until after I committed. I will make those changes; is it OK to update this review, or should I create a new one?

A new one is great. Just treat this as post commit :)

> As for choosing limited it was just what the function adding the debug info checked for as a minimum; what would you generally choose instead?

I'd have just suggested plain -g for it?



More information about the cfe-commits mailing list