r338291 - Remove trailing space

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 13:36:23 PDT 2018

On Mon, Jul 30, 2018 at 4:24 PM, Michael Kruse
<llvm-commits at meinersbur.de> wrote:
> I think removing trailing space is a good thing. Some editors remove
> any trailing space when saving a file. This shows up in diffs that I
> then have to undo manually.

I've also run into the same issues on occasion. However, this isn't
about whether we dislike trailing spaces or not; it's about NFC churn
for out of tree users who have to try to keep their local patches
clean against upstream. This kind of churn makes for merge conflicts
and this is a the reason the community has traditionally rejected
these large-scale commits in the past. If we want to change that
policy, it should come after community discussion and agreement.


More information about the cfe-commits mailing list