[PATCH] D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 13:11:52 PDT 2018

echristo added a comment.

The patch is fine, in general, couple of comments:

a) Can you refactor this so the if conditionals are just two functions? Those functions are big enough already.
b) I'm not quite sure why you're picking limited here, do you have an explanation?
c) Can you split that part out into a separate test? Additional run lines in the existing blocks.cl test would be fine.


  rC Clang


More information about the cfe-commits mailing list