[PATCH] D49914: [libc++] Add the _LIBCPP_HIDE_FROM_ABI_AFTER_V1 macro

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 08:14:48 PDT 2018

mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

This LGTM, but suggests another cleanup.

We have a bunch of `_LIBCPP_BUILDING_XXX` macros defined in libcxx/src - do we need them any more now that we have `_LIBCPP_BUILDING_LIBRARY`?

  src/bind.cpp:10: #define _LIBCPP_BUILDING_BIND
  src/memory.cpp:10: #define _LIBCPP_BUILDING_MEMORY
  src/mutex.cpp:10: #define _LIBCPP_BUILDING_MUTEX
  src/new.cpp:10: #define _LIBCPP_BUILDING_NEW
  src/shared_mutex.cpp:13: #define _LIBCPP_BUILDING_SHARED_MUTEX
  src/system_error.cpp:12: #define _LIBCPP_BUILDING_SYSTEM_ERROR
  src/utility.cpp:10: #define _LIBCPP_BUILDING_UTILITY

I can take care of this post-branch for release.

  rCXX libc++


More information about the cfe-commits mailing list