[PATCH] D49967: [clangd] Add command-line option to suppress the space and the circular dot prepended in a completion label.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 29 11:40:33 PDT 2018


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Makes sense, thanks!



================
Comment at: clangd/tool/ClangdMain.cpp:161
+static llvm::cl::opt<bool> NoHeaderInsertDecorators(
+    "no-header-insert-decorators",
+    llvm::cl::desc(
----------------
Please invert the sense of this to avoid a double negative: "header-insert-decorators" with default true.

Consider insert->insertion, because currently is not clear whether to read as (header (insert decorators)) or as ((header insert) decorators).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49967





More information about the cfe-commits mailing list