[PATCH] D49885: Thread safety analysis: Allow relockable scopes

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 28 12:43:11 PDT 2018


aaronpuchert marked 3 inline comments as done.
aaronpuchert added inline comments.


================
Comment at: lib/Analysis/ThreadSafety.cpp:960-961
+        FSet.removeLock(FactMan, !UnderCp);
+        FSet.addLock(FactMan, llvm::make_unique<LockableFactEntry>(UnderCp, LK,
+                                                                   RelockLoc));
+      }
----------------
aaron.ballman wrote:
> aaronpuchert wrote:
> > Looks a bit weird, but `clang-format` told me to do that.
> This line looks correct to me, but the `else` statement above doesn't match our usual formatting rules, so I'm worried you're running clang-format in a way that's not picking up the LLVM coding style options.
You're right about the `else`, not sure what happened there.


Repository:
  rC Clang

https://reviews.llvm.org/D49885





More information about the cfe-commits mailing list