[PATCH] D49650: Targets/AMDGPU: Don't set fp32-denormals feature for r600

Jan Vesely via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 27 14:04:11 PDT 2018


jvesely abandoned this revision.
jvesely added a comment.

In https://reviews.llvm.org/D49650#1177323, @jvesely wrote:

> In https://reviews.llvm.org/D49650#1176336, @arsenm wrote:
>
> > In https://reviews.llvm.org/D49650#1175461, @jvesely wrote:
> >
> > > In https://reviews.llvm.org/D49650#1175438, @arsenm wrote:
> > >
> > > > According to cayman manual, these registers do exist so we should probably just make the feature accepted on r600 as well
> > >
> > >
> > > sure, that's the way it was before r335942. I assumed the removal was intentional.
> >
> >
> > Probably accidental because nothing in r600 was actually using it
>
>
> given the number of warnings it outputs, I find that unlikely.
>  @tstellar what was your intention? It's not like someone is going to work on EG/CM denormals any time soon.
>
> I don't mind either way. I just want to avoid another round of bikeshedding.


https://reviews.llvm.org/D49934


Repository:
  rC Clang

https://reviews.llvm.org/D49650





More information about the cfe-commits mailing list