[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 27 13:34:48 PDT 2018


ldionne added a comment.

In https://reviews.llvm.org/D49317#1178767, @Quuxplusone wrote:

> @ldionne: I don't know if your "LGTM" is necessarily sufficient to commit this or not; but either way, I don't have commit privs, so could I ask you (or someone else) to commit this on my behalf? Thanks!


I would not dare say that my LGTM is sufficient. My goal in reviewing this was to lower the barrier for a more senior contributor (Eric/Marshall) to give a definitive LGTM.


Repository:
  rCXX libc++

https://reviews.llvm.org/D49317





More information about the cfe-commits mailing list