[PATCH] D49927: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 27 12:18:07 PDT 2018


ldionne added a comment.

Just to make sure I understand properly: this means we will use newlib's implementation of `iswcntrl_l` & friends instead of our own emulation (which is an ODR violation currently going unnoticed)? And this is OK because newlib provides `iswcntrl_l` & friends starting at version 2.4.

This is my understanding. If it is correct, then LGTM.


Repository:
  rCXX libc++

https://reviews.llvm.org/D49927





More information about the cfe-commits mailing list