[PATCH] D49766: Fix a crash when an error occurs in Template and the initializer is a nullptr for C++17

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Do you have your commit rights yet?



================
Comment at: include/clang/AST/TemplateBase.h:469
+
+    // Allow more additional argument kinds for the constructor.
+    assert(Argument.getKind() == TemplateArgument::NullPtr ||
----------------
This comment sounds pretty strange, how about "Permit any kind of template argument that can be represented with an expression"?


Repository:
  rC Clang

https://reviews.llvm.org/D49766