[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 27 07:03:32 PDT 2018


krasimir marked an inline comment as done.
krasimir added inline comments.


================
Comment at: lib/Format/BreakableToken.cpp:526
+      0, Content[LineIndex].find_first_of(Blanks));
+  if (FirstWord == "@param")
+    return Style.ContinuationIndentWidth;
----------------
mprobst wrote:
> Shouldn't this check the set above?
ahahah, sure!


================
Comment at: unittests/Format/FormatTestComments.cpp:3154
+
+  EXPECT_EQ("/**\n"
+            " * @param l1 long1\n"
----------------
mprobst wrote:
> do we already have a test that `@param {oh noes this is really long} foo` isn't broken?
As discussed offline, we'll gonna go with breaking that.


Repository:
  rC Clang

https://reviews.llvm.org/D49797





More information about the cfe-commits mailing list