[PATCH] D49715: [analyzer] CallEvent: Add partially working methods for obtaining the callee stack frame.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 26 11:39:06 PDT 2018


NoQ added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:197
+
+  // Recover CFG block via reverse lookup. Maybe it should just be a part of the
+  // CallEvent object? That would have been convenient.
----------------
george.karpenkov wrote:
> Can we remove "maybe" / "that would have been" comments?
Changed them into a TODO because they're rather important to keep. Like, that's a flaw in this code.


https://reviews.llvm.org/D49715





More information about the cfe-commits mailing list