[PATCH] D49523: [clangd] Add support for per-file override compilation command

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 26 08:52:03 PDT 2018


arphaman added a comment.

In https://reviews.llvm.org/D49523#1174627, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D49523#1174086, @arphaman wrote:
>
> > We actually need both mechanisms. I posted the didChangeConfiguration extension to https://reviews.llvm.org/D49758.
>
>
> Why do we need both? Can we have only the one from https://reviews.llvm.org/D49758 and send two requests (compile command changed for file 'X' + didOpen('X')) whenever a new file gets added?


The didChangeConfiguration command would re-parse all the open documents, which is something we want to avoid. I guess one solution is to avoid reparsing anything when the updated file is not in the database in the first place. I'll work on that.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49523





More information about the cfe-commits mailing list