[PATCH] D49729: [AST][1/4] Move the bit-fields from TagDecl, EnumDecl and RecordDecl into DeclContext

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: include/clang/AST/Decl.h:3333
+
+  /// True if this is a C++11 scoped enumeration.
+  void setScopedUsingClassTag(bool ScopedUCT = true) {
----------------
This is the same comment as 3330, perhaps a copy/paste error?


================
Comment at: lib/AST/Decl.cpp:3896
+  assert(Scoped || !ScopedUsingClassTag);
+  IntegerType = (const Type *)nullptr;
+  setNumPositiveBits(0);
----------------
This cast is jarring.  C-Style casts shouldn't be used (i realize it is in the source), and I'm not sure it is necessary here.  Can you try removing the cast entirely?


Repository:
  rC Clang

https://reviews.llvm.org/D49729