[PATCH] D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 26 03:50:53 PDT 2018


jkorous added a comment.

I like that idea! It looks like it's living in a wrong place anyway as it doesn't need access to any of implementation details (private members) of DiagnosticID. I would still like to preserve it as a function so this block of code has clear semantics and interface. 
How about I refactor it to a static free function in Warnings.cpp?


Repository:
  rC Clang

https://reviews.llvm.org/D49736





More information about the cfe-commits mailing list