[PATCH] D49589: [UBSan] Strengthen pointer checks in 'new' expressions
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 25 10:40:46 PDT 2018
rjmccall added inline comments.
================
Comment at: lib/CodeGen/Address.h:46
+ return IsChecked;
+ }
+
----------------
`Address` is a pretty low-level type to be changing here. Is this necessary? Can you find a way to propagate this just in higher-level types like `AggValueSlot`, `RValue`, and `LValue`?
Also, please remember that your analysis is not the only thing happening in the compiler. `isChecked` is not a meaningful name taken out of context.
Repository:
rC Clang
https://reviews.llvm.org/D49589
More information about the cfe-commits
mailing list