[PATCH] D49701: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 25 04:41:03 PDT 2018


aaron.ballman added a comment.

The docs do not look correct to me. For instance, I don't see any changes to the `hasDeclaration()` documentation for the newly supported type. There also appear to be a bunch of unrelated changes in the generated HTML.



================
Comment at: clang/docs/LibASTMatchersReference.html:3292-3294
+  [x containsString:@"h"];
 but not
+  [NSString stringWithFormat:@"format"];
----------------
I thought these changes already went in as a separate commit? These are unrelated to the patch.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:44
 #include "clang/AST/Expr.h"
+#include "clang/AST/ExprObjC.h"
 #include "clang/AST/ExprCXX.h"
----------------
This list should remain sorted alphabetically.


https://reviews.llvm.org/D49701





More information about the cfe-commits mailing list