[PATCH] D49771: CodeGen: use non-zero memset when possible for automatic variables

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 24 21:23:02 PDT 2018


jfb marked an inline comment as done.
jfb added a comment.

Addressed all comments.



================
Comment at: lib/CodeGen/CGDecl.cpp:956-957
+class BytePattern {
+  uint8_t Val;
+  enum class ValueType { Specific, Any, None } Type;
+  BytePattern(ValueType Type) : Type(Type) {}
----------------
bogner wrote:
> Probably makes sense to swap the order of these or give the enum class a smaller underlying type than int.
I defined the enum class' storage type as `uint8_t`.


Repository:
  rC Clang

https://reviews.llvm.org/D49771





More information about the cfe-commits mailing list