[PATCH] D49523: [clangd] Add support for per-file override compilation command
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 24 14:05:12 PDT 2018
arphaman added a comment.
In https://reviews.llvm.org/D49523#1171484, @ilya-biryukov wrote:
> The extensions itself seems like a reasonable way to provide compile commands for the individual files. In case didChangeConfiguration does not work for you for some reason, happy to take a look at this change too.
> One drawback of using didChangeConfiguration for compile commands is that it forces global invalidation, which may be a bad thing if your client tracks compile commands on a smaller scale and can send requests to invalidate individual files. However, if you're happy with it, we might get away with not adding yet another mechanism to pass compile commands to clangd, which is definitely a good thing!
We actually need both mechanisms. I posted the didChangeConfiguration extension to https://reviews.llvm.org/D49758.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49523
More information about the cfe-commits
mailing list