[PATCH] D49749: [analyzer] Admit that we can't simplify the newly produced mixed Loc/NonLoc expressions.

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 24 13:02:32 PDT 2018


george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1300
+          Loc::isLocType(S->getRHS()->getType())) {
+        SVal V = SVB.makeSymbolVal(S);
+        Cached[S] = V;
----------------
could we eliminate the code duplication with lines 1308-1310?


Repository:
  rC Clang

https://reviews.llvm.org/D49749





More information about the cfe-commits mailing list