[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 23 20:42:45 PDT 2018


ldionne added a comment.

LGTM. FWIW, I'm really not a huge fan of all these different ways of building libc++. There should be one canonical way of doing it, and it should be simple. However, it seems like this patch is the right thing to do given the changes that have already been made to account for specific use cases.

IOW, I don't like this whole trend, but we're already down that road.


Repository:
  rCXX libc++

https://reviews.llvm.org/D49711





More information about the cfe-commits mailing list