[PATCH] D49647: [libcxx] Library support for contracts (C++2a)

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 23 10:34:42 PDT 2018


mclow.lists added a comment.

I'd like to be clear that I'm not against using `ASSERT_NOEXCEPT` or `ASSERT_SAME_TYPE` - that's fine.
But I'd rather you use `declval<>` - which is only useful in an unevaluated context, rather than having a function that takes a parameter - which someone might actually call.

Also, then you can move all the tests into `main` and get rid of the function.


https://reviews.llvm.org/D49647





More information about the cfe-commits mailing list